Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate content format and sending in PushGatewayPublisher #110

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

vipsy
Copy link
Contributor

@vipsy vipsy commented Sep 12, 2019

Added public methods to get formatted content suitable for PushGateway
but without sending it. This can be helpful in cases where you have
some middleware where you want to send this data which eventually
pushes to your pushgateway.

Added public methods to get formatted content suitable for PushGateway
but without sending it. This can be helpful in cases where you have
some middleware where you want to send this data which eventually
pushes to your pushgateway.
@vipsy
Copy link
Contributor Author

vipsy commented Sep 12, 2019

@cdsap the commit message above explains why I need just the data without publishing them.

@vipsy
Copy link
Contributor Author

vipsy commented Sep 12, 2019

I realised without separating formatter, I wont be able to use it in my custom publisher.
So created a formatter class. It's in the same package right now.
Feel free to suggest an appropriate package for it.

@cdsap
Copy link
Owner

cdsap commented Sep 12, 2019

hi @vipsy, thank you very much for the contribution.
I see ok the changes.
Related to the package name, it could be:
com.cdsap.talaiot.formatter
or
com.cdsap.talaiot.publisher.pushgateway including in this new package the publisher and the formater

@vipsy
Copy link
Contributor Author

vipsy commented Sep 13, 2019

hi @cdsap I have moved them to com.cdsap.talaiot.publisher.pushgateway package to be consistent with graphpublisher and timeline

@cdsap
Copy link
Owner

cdsap commented Sep 13, 2019

perfect, merging. Next release will be published next week. After closing issue #93

Thank you!

@cdsap cdsap merged commit 1ed28b3 into cdsap:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants