[8.x] Fix laravel#38949 (laravel#38962)

* This should fix laravel#38949 * apply ci fixes
cdsistemas · Oct 12, 2021 · 15101ba · 15101ba
1 parent b1df976
commit 15101ba
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Illuminate/Validation/Rules/Password.php b/src/Illuminate/Validation/Rules/Password.php
@@ -268,6 +268,8 @@ public function symbols()
      */
     public function passes($attribute, $value)
     {
+        $this->messages = [];
+
         $validator = Validator::make($this->data, [
             $attribute => 'string|min:'.$this->min,
         ], $this->validator->customMessages, $this->validator->customAttributes);

diff --git a/tests/Validation/ValidationPasswordRuleTest.php b/tests/Validation/ValidationPasswordRuleTest.php
@@ -232,6 +232,29 @@ public function testItCannotSetDefaultUsingGivenString()
         Password::defaults('required|password');
     }
 
+    public function testItPassesWithValidDataIfTheSameValidationRulesAreReused()
+    {
+        $rules = [
+            'password' => Password::default(),
+        ];
+
+        $v = new Validator(
+            resolve('translator'),
+            ['password' => '1234'],
+            $rules
+        );
+
+        $this->assertFalse($v->passes());
+
+        $v1 = new Validator(
+            resolve('translator'),
+            ['password' => '12341234'],
+            $rules
+        );
+
+        $this->assertTrue($v1->passes());
+    }
+
     protected function passes($rule, $values)
     {
         $this->assertValidationRules($rule, $values, true, []);