-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve lint, build, CI, and release process #42
Conversation
@ablyler can you take a look at this when you have time? 🙇🏻 |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports You could have same capabilities but better runtime performances if you request a new MegaLinter flavor. |
f69aff9
to
2519520
Compare
One unknown: when running the minimal from-scratch Docker image, will TLS validation be a problem for the Ecobee API / if anyone is running InfluxDB with TLS? |
@theonlytruebigmac curious to hear any input you have on this, too 🙇🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Very nice improvements!
I'll try to build the docker image and run it against this branch. I do not have TLS enabled for InfluxDB, but I can test the Ecobee API. |
Signed-off-by: Andy Blyler <andy@blyler.cc>
Signed-off-by: Andy Blyler <andy@blyler.cc>
I had to make some minor changes to get the docker image to work correctly, including adding the ca certs. It works on my machine now. 👍 |
@ablyler awesome, thanks! Next year's first (planned) Big House Expense is likely going to be new HVAC, and then I'll have an Ecobee to test with again ;) |
Now letting v1.0.0-rc.1 build: https://github.com/cdzombak/ecobee_influx_connector/actions/runs/6263222668 \o/ |
Motivated by recent work with Docker and GitHub Actions on a personal project, plus this repo's insistence on trying to push PR branches to Docker, I've revamped how this repo is versioned, linted, built, and released:
-version
flag.make
with no targets ormake help
.main
,v*.*.*
tags, and PRs.vX.Y.Z
tag is pushed. Binaries and .debs are attached.vX.Y.Z-alpha.A
,-beta.B
, and-rc.N
are also supported. These generate a GitHub prerelease.latest
,X.Y.Z
,X.Y
, andX
are pushedmain
: themain
tag is pushed