-
Notifications
You must be signed in to change notification settings - Fork 94
Closed
Labels
Milestone
Description
Symfony bug symfony/symfony#34805 seems to be fixed so we should be able to remove these checks:
php-openapi/tests/ReaderTest.php
Lines 97 to 109 in ba2f0cf
| // skip test on symfony/yaml 5.0 due to bug https://github.com/symfony/symfony/issues/34805 | |
| $installed = json_decode(file_get_contents(__DIR__ . '/../vendor/composer/installed.json'), true); | |
| // Check for composer 2.0 structure | |
| if (array_key_exists('packages', $installed)) { | |
| $installed = $installed['packages']; | |
| } | |
| foreach($installed as $pkg) { | |
| if ($pkg['name'] === 'symfony/yaml' && version_compare($pkg['version'], 'v4.4', '>=')) { | |
| $this->markTestSkipped( | |
| 'This test is incompatible with symfony/yaml 4.4 and 5.0, see symfony bug https://github.com/symfony/symfony/issues/34805' | |
| ); | |
| } | |
| } |
php-openapi/tests/spec/OpenApiTest.php
Lines 191 to 205 in ba2f0cf
| // skip test on symfony/yaml 5.0 due to bug https://github.com/symfony/symfony/issues/34805 | |
| if ($openApiFile === 'oai/openapi-specification/examples/v3.0/uspto.yaml') { | |
| $installed = json_decode(file_get_contents(__DIR__ . '/../../vendor/composer/installed.json'), true); | |
| // Check for composer 2.0 structure | |
| if (array_key_exists('packages', $installed)) { | |
| $installed = $installed['packages']; | |
| } | |
| foreach ($installed as $pkg) { | |
| if ($pkg['name'] === 'symfony/yaml' && version_compare($pkg['version'], 'v4.4', '>=')) { | |
| $this->markTestSkipped( | |
| 'This test is incompatible with symfony/yaml 4.4 and 5.0, see symfony bug https://github.com/symfony/symfony/issues/34805' | |
| ); | |
| } | |
| } | |
| } |