Skip to content

Allow Symfony 7 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow Symfony 7 #203

wants to merge 1 commit into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Feb 5, 2024

No description provided.

@tacman
Copy link
Contributor Author

tacman commented Jun 25, 2024

any downside to merging this?

@cebe cebe mentioned this pull request Nov 13, 2024
@cebe
Copy link
Owner

cebe commented Nov 13, 2024

Tests are failing on php 8.2 #212

@tacman
Copy link
Contributor Author

tacman commented Nov 13, 2024

yes, but that's not related to Symfony 7, is it?

@tacman
Copy link
Contributor Author

tacman commented Nov 13, 2024

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

If it's a new release, I'd even say just ^6.4 || ^7, since 5.4 is near EOL

@tacman tacman mentioned this pull request Nov 14, 2024
@cebe cebe added this to the 1.8.0 milestone Nov 14, 2024
@cebe
Copy link
Owner

cebe commented Nov 14, 2024

yes, but that's not related to Symfony 7, is it?

I did not know whether it's related or not so I wanted to wait for tests to pass.

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

what's the point in dropping versions that work fine, breaking someones code? Dropping old versions is fine if it is complicated to support these. For Symfony YAML I'd keep it as widely compatibly as possible.

@cebe
Copy link
Owner

cebe commented Nov 14, 2024

Your commit is merged in #212, thanks!

@cebe cebe closed this Nov 14, 2024
@prajapati-kaushik
Copy link

@cebe: I suppose, brach merged but a new version 7.1 release is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants