Pull development into main ahead of tagged release #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done so as to allow a general/default retry delays tuple to be specified.
The callback wrapper now implements the transaction-level retries made possible by the refactoring of Retries outside of the PathDetails object. Some things to note: - All messages that fail in the accepted number of ways denoted in the try-catch block in teh callback wrapper will be retried. We may in the future want to expand this to all Exceptions and expand what throws errors within the callback so it is applied more widely. - Only the final reason is stored alonside the FailedFile record in the monitoring database, which can be either a File-level Retry Reason or a Transaction-level Retry Reason. We may in the future want to store more than one reason if they exist but this will do for now. - All retries are reset upon successful completion of a callback, both FRs and TRs
Documentation update for release
…d that doesn't exist
Fix for modify holding attribute error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.