two bugfixes - see full description #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seen until after self.catalog.save() is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugfixes.
One fixes a problem that
nlds meta -i ...doesn't work properly (the call doesn't allow for thegroupallpositional arg, so arguments are passed to the wrong parameter in the function). This is line 1616 and should be straightforward to review.The other fixes the fact that (once the above is fixed) the new_meta is reported incorrectly: it is just a copy of the old_meta, because the catalog has not yet been saved. This might require more careful review, although it works when I test it manually. (Maybe we also need a test for this.)