Use unwrap_or_clone instead of (*foo).clone()

Signed-off-by: John Kastner <jkastner@amazon.com>
cedar-policy · Dec 31, 2024 · c43279e · c43279e
1 parent e3e6d85
commit c43279e
Show file tree

Hide file tree

Showing 3 changed files with 109 additions and 99 deletions.
diff --git a/cedar-policy-core/src/ast/policy_set.rs b/cedar-policy-core/src/ast/policy_set.rs
@@ -433,7 +433,7 @@ impl PolicySet {
         match self.templates.remove(policy_id) {
             Some(t) => {
                 self.template_to_links_map.remove(policy_id);
-                Ok((*t).clone())
+                Ok(Arc::unwrap_or_clone(t))
             }
             None => panic!("Found in template_to_links_map but not in templates"),
         }