Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for keywords #1222

Open
1 of 7 tasks
khieta opened this issue Sep 23, 2024 · 2 comments
Open
1 of 7 tasks

Add tests for keywords #1222

khieta opened this issue Sep 23, 2024 · 2 comments
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@khieta
Copy link
Contributor

khieta commented Sep 23, 2024

Describe the improvement you'd like to request

Add tests for the use of keywords in Cedar and JSON formats to make sure that 1) the results are what we expect and 2) the parser error messages make sense.

We should test:

  • Cedar policy format
  • JSON policy format
  • Cedar schema format
  • JSON schema format
  • JSON entity/context format

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@khieta khieta added backlog internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice labels Sep 23, 2024
@khieta
Copy link
Contributor Author

khieta commented Sep 23, 2024

Cedar policy tests added in #1223. Tests include the keywords "true", "false", "if", "then", "else", "in", "like", "has", "is", "__cedar", "principal", "action", "resource", "context", "permit", "forbid", "when", "unless".

@john-h-kastner-aws
Copy link
Contributor

john-h-kastner-aws commented Sep 23, 2024

ref #407 for "parser error messages make sense."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Development

No branches or pull requests

2 participants