Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for reserved keywords in policies #1223

Merged
merged 2 commits into from
Sep 23, 2024
Merged

add tests for reserved keywords in policies #1223

merged 2 commits into from
Sep 23, 2024

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Sep 23, 2024

Description of changes

Adds some tests to check when keywords are allowed/not allowed in policies. I was using these to check whether our docs were up-to-date, but figured they might be useful to add to the repo so we can track changes. I found this a useful exercise, which led me to open #1221, and I think we should do this for more formats (#1222).

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests <3

@khieta khieta merged commit e8225a8 into main Sep 23, 2024
19 checks passed
@khieta khieta deleted the khieta/keywords branch September 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants