More tasks from #745 #1036
Closed
More tasks from #745 #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
aaronjeline
requested review from
cdisselkoen and
khieta
and removed request for
cdisselkoen
cdisselkoen
reviewed
Jul 2, 2024
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
cdisselkoen
reviewed
Jul 3, 2024
Comment on lines
+556
to
557
| /// Creates a duplicate keys error | ||
| pub fn duplicate_keys(key: SmolStr, loc1: Loc, loc2: Loc) -> Self { |
There was a problem hiding this comment.
Since this type is publicly exposed, end-users can see and use these constructors, and we have to commit to stability for their arguments. I think it would be better if we could avoid (at least fully pub) constructors, so that in the future we could add or change arguments as necessary?
There was a problem hiding this comment.
agreed. I think our error constructors are generally not public
Comment on lines
+556
to
557
| /// Creates a duplicate keys error | ||
| pub fn duplicate_keys(key: SmolStr, loc1: Loc, loc2: Loc) -> Self { |
There was a problem hiding this comment.
agreed. I think our error constructors are generally not public
11 tasks
|
Superseded by #1129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleans up two remaining error tasks
EntityUid::from_jsonreturns a concrete type instead of an existentialHumanSchemaError::Parseis more transparentIssue #, if available
#745
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):