Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non_exhaustive to more error types #1137

Merged
merged 2 commits into from
Aug 9, 2024
Merged

add non_exhaustive to more error types #1137

merged 2 commits into from
Aug 9, 2024

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Aug 9, 2024

Description of changes

Adds non_exhaustive to some error types that would be reasonable to extend in the future (IMO). What prompted this was that I wanted to backport #890 to 3.3.x, but found that I couldn't due to a new variant in SchemaError. This would have been fine if the error type had been non-exhaustive.

Also includes a quick fix to a comment in api.rs.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

@khieta khieta merged commit 0c7fe67 into main Aug 9, 2024
18 of 19 checks passed
@khieta khieta deleted the khieta/4.0-nits branch August 9, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants