-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level validation Rust implementation (RFC 76) #1146
Conversation
Signed-off-by: Andrew Wells <anmwells@amazon.com>
a3049c7
to
3daa6b3
Compare
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly different the lean impl. In the lean impl Level 0
is the level that can't be de-referenced. I think they should align on that. Otherwise, looks good. Very different algorithm to the lean, but I think you said that was so you can get better error messages.
Signed-off-by: Andrew Wells <anmwells@amazon.com>
That's my understanding too. Each node's |
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Signed-off-by: Andrew Wells <anmwells@amazon.com>
Description of changes
Rust implementation of Level validation (RFC 76: cedar-policy/rfcs#76)
@aaronjeline is working on Lean changes.
Example error messages:
![Screenshot 2024-08-16 at 3 23 47 PM](https://private-user-images.githubusercontent.com/130512013/358744036-b1988f73-48a0-46ef-aac9-ea8661af91db.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTE4NTAsIm5iZiI6MTczOTU1MTU1MCwicGF0aCI6Ii8xMzA1MTIwMTMvMzU4NzQ0MDM2LWIxOTg4ZjczLTQ4YTAtNDZlZi1hYWM5LWVhODY2MWFmOTFkYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxNjQ1NTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMDY3YjMyMzQyODA3MjAyZWRjYmFjNWE5YTFjY2MyMTFiOWY2OWUwOGJkODRkZmM4YjEwYjMwZGE2NmVlNWM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7YTzrWedxaVJTJSvQvvONQxqtvIqIRWurBJTiAgmCXM)
Issue #, if available
RFC 76 (cedar-policy/rfcs#76)
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)