Implement #1139 #1150
Merged
Implement #1139 #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
requested review from
cdisselkoen,
john-h-kastner-aws and
khieta
and removed request for
cdisselkoen and
john-h-kastner-aws
Signed-off-by: Shaobo He <shaobohe@amazon.com>
cdisselkoen
approved these changes
Aug 27, 2024
john-h-kastner-aws
approved these changes
Aug 27, 2024
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
john-h-kastner-aws
approved these changes
Aug 28, 2024
shaobo-he-aws
deleted the
1139-more-restrictions-on-type-shadowing-collisions
branch
Merged
oflatt
pushed a commit
to oflatt/cedar
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com> Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
oflatt
pushed a commit
to oflatt/cedar
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com> Co-authored-by: Craig Disselkoen <cdiss@amazon.com> Signed-off-by: oflatt <oflatt@gmail.com>
2 tasks
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR eagerly disallows common type declarations with names specified by #1139. That is, Cedar forbids schemas with such declarations even though they are never referenced.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):