Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non_exhaustive to a couple more types #1169

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

cdisselkoen
Copy link
Contributor

@cdisselkoen cdisselkoen commented Sep 3, 2024

Description of changes

Adds non_exhaustive to a couple more error types related to parsing or validation. Most of our public error types related to parsing or validation already had non_exhaustive.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

  • updates the CHANGELOG appropriately

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen requested a review from khieta September 3, 2024 19:13
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen merged commit d846083 into main Sep 4, 2024
18 of 19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/non-exhaustive branch September 4, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants