Add methods to get number of policies and templates in a PolicySet #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy set has cedar-policy#1179 Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com>
Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com>
Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com>
cdisselkoen
reviewed
Sep 6, 2024
cedar-policy/CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ Starting with version 3.2.4, changes marked with a star (*) are _language breaki | |||
|
|
|||
| ## [Unreleased] | |||
| Cedar Language Version: TBD | |||
| * Add convenience methods to see how many policies and templates a policy set has (#1179). | |||
There was a problem hiding this comment.
nit: can we put this in the Added section (three lines below)?
cedar-policy/src/api.rs
Outdated
| @@ -2057,6 +2057,18 @@ impl PolicySet { | |||
| self.ast.is_empty() | |||
| } | |||
|
|
|||
| /// Returns the number of `Template`s in the `PolicySet`. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns the number of `Template`s in the `PolicySet`. | |
| /// Returns the number of `Policy`s in the `PolicySet`. |
There was a problem hiding this comment.
Ah, copy paste mishap, let me fix this.
Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com>
cdisselkoen
approved these changes
Sep 6, 2024
shaobo-he-aws
approved these changes
Sep 7, 2024
|
One of the checks failed, is this a known issue? I'd probably need a bit of help to fix it if needed. |
|
It's a problem unrelated to the change in this PR. Given that, happy to merge this now -- looks like we have 2 approvals and the CI failures are unrelated. |
aaronjeline
pushed a commit
that referenced
this pull request
Sep 10, 2024
…1180) Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com> Co-authored-by: Juan Vicente Garcia Orozco <juano@amazon.com>
khieta
pushed a commit
that referenced
this pull request
Sep 10, 2024
…1180) Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com> Co-authored-by: Juan Vicente Garcia Orozco <juano@amazon.com>
khieta
pushed a commit
that referenced
this pull request
Sep 10, 2024
…1180) Signed-off-by: Juan Vicente Garcia Orozco <juano@amazon.com> Co-authored-by: Juan Vicente Garcia Orozco <juano@amazon.com>
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add methods to get number of policies and templates in a PolicySet.
Regarding unit testing, I decided to just reuse this API in previous places where the size of existing iterators are used, it feels like more effort would feel silly here.
Issue #, if available
#1179
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)