Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getTag and hasTag operations to AST, EST, policy parser, and evaluator #1207

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

Handle getTag and hasTag operations in AST, EST, policy parser, and evaluator

Issue #, if available

Part of RFC 82

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

…Is yet

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…uator

including tests for all of these as appropriate

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…aluator

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen merged commit cc81891 into main Sep 18, 2024
17 of 19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/rfc-82-evaluator branch September 18, 2024 21:05
shaobo-he-aws pushed a commit that referenced this pull request Sep 25, 2024
…evaluator (#1207)

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants