-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add getTag
and hasTag
operations to AST, EST, policy parser, and evaluator
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Is yet Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…uator including tests for all of these as appropriate Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…aluator Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
john-h-kastner-aws
approved these changes
Sep 17, 2024
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
shaobo-he-aws
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
shaobo-he-aws
approved these changes
Sep 18, 2024
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
shaobo-he-aws
approved these changes
Sep 18, 2024
shaobo-he-aws
pushed a commit
that referenced
this pull request
Sep 25, 2024
…evaluator (#1207) Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Handle
getTag
andhasTag
operations in AST, EST, policy parser, and evaluatorIssue #, if available
Part of RFC 82
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)