Entity Slicing: EntityLoader trait
#1208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
oflatt
changed the title
EntityLoader] trait for entity slicingEntityLoader trait
This was referenced Sep 16, 2024
oflatt
commented
Sep 16, 2024
| @@ -492,6 +492,13 @@ impl Entity { | |||
| pub(crate) fn add_ancestor(&mut self, uid: EntityUID) { | |||
| self.ancestors.insert(uid); | |||
| } | |||
|
|
|||
| /// Add a set of ancestors to this `Entity`. | |||
| /// TODO why is `add_ancestor` pub(crate) instead of pub, and should this be too? | |||
There was a problem hiding this comment.
Question here on if this can be public
oflatt
changed the base branch from
oflatt/entity-manifest-ancestors
to
oflatt/entity-manifest-type-annotated
This was referenced Sep 16, 2024
|
Closed in favor of a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a new way to load entities based on their ids. This makes entity slicing easier to implement, since the trait implementor does not need to worry about entity dereferences. To make this PR work, type annotations had to be added to the entity manifest.
The API is flexible: users can choose to use the [
AccessTrie] in entity requests to only load some fields of entities. It's also batched, so that as many entities as possible are loaded at the same time (in a breadth-first traversal of the entity manifest).Loading of ancestors is separated from loading of entities so that particular ancestors can be named.
This PR doesn't make this API public yet, but it could be made public with some wrapper structs.
PR stack:
#1102
#1105
#1154
#1156
#1171
#1196
#1208 (This PR)
DRT testing PR: cedar-policy/cedar-spec#429
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)