Generate actions HashMap at ValidatorSchema instantiation #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Paulus <tpaulus@cloudflare.com>
tpaulus
force-pushed
the
1285-core-schema-performance
branch
from
5fb58b5 to
80b7ebc
Compare
tpaulus
force-pushed
the
1285-core-schema-performance
branch
from
a35ebf1 to
a5865a4
Compare
2 tasks
Signed-off-by: Tom Paulus <tpaulus@cloudflare.com>
tpaulus
force-pushed
the
1285-core-schema-performance
branch
from
6208ac7 to
2ef2f90
Compare
Signed-off-by: Tom Paulus <tpaulus@cloudflare.com>
tpaulus
force-pushed
the
1285-core-schema-performance
branch
from
2f5e11f to
02db858
Compare
adpaco-aws
approved these changes
Oct 25, 2024
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com> Signed-off-by: Tom Paulus <tpaulus@cloudflare.com>
tpaulus
force-pushed
the
1285-core-schema-performance
branch
from
fc7fd1a to
c2dc40a
Compare
john-h-kastner-aws
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change fixes part of the issues identified in #1285 by pulling up the expensive action inversion from CoreSchema construction to ValidatorSchema construction, which is only done once per Schema.
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):