Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate docs for the protobuf feature #1434

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Do not generate docs for the protobuf feature #1434

merged 1 commit into from
Jan 21, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Jan 21, 2025 •
edited
Loading

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

@shaobo-he-aws
Do not generate docs for the protobuf feature
863c503 
Signed-off-by: Shaobo He <shaobohe@amazon.com>
@cdisselkoen cdisselkoen mentioned this pull request Jan 21, 2025
Open
2 tasks
@shaobo-he-aws
Copy link
Contributor Author

Will update the changelog tomorrow.

@shaobo-he-aws shaobo-he-aws merged commit 604c6a1 into release/4.3.x Jan 21, 2025
16 of 19 checks passed
@shaobo-he-aws shaobo-he-aws deleted the chore/shaobo/fix-doc-build branch January 21, 2025 21:54
shaobo-he-aws added a commit that referenced this pull request Jan 22, 2025
@shaobo-he-aws
Do not generate docs for the protobuf feature (#1434)
49267e0 
Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws added a commit that referenced this pull request Jan 22, 2025
@shaobo-he-aws @cdisselkoen
Backport #1434 to main (#1438)
2aa652e 
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdisselkoen cdisselkoen cdisselkoen approved these changes

@adpaco-aws adpaco-aws adpaco-aws approved these changes

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaobo-he-aws @cdisselkoen @adpaco-aws @john-h-kastner-aws