Implement a faster version of FromNormalizedStr
for Name
s
#1486
+63
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In #1411 we discussed an approach to significantly improve performance of this code, which happens to be consuming quite a lot of CPU time in our team's use of Cedar. This is a more formal attempt to implement it. I've had this stashed locally for a while, but I won't be able to work on this for a few weeks, so I wanted to get the PR out and at least get some discussions started on whether this is a good idea and what might be missing if it is.
Performance does seem to be significantly better given benchmarking results, examples:
This of course comes at the cost of having to maintain this somewhat duplicated specific parser for these bits. Given the performance gains, the benefit seems worth to me, but well, this is something that should be discussed for its long-term maintainability.
I also haven't researched if there are better ways to accomplish better performance with the current framework, so there might be some opportunities there.
Issue #, if available
#1411
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).cedar-policy
(e.g., addition of a new API).cedar-policy
.cedar-policy-core
,cedar-validator
, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)cedar-spec
. (Post your PR anyways, and we'll discuss in the comments.)I confirm that
docs.cedarpolicy.com
(choose one, and delete the other options):cedar-docs
. PRs should be targeted at astaging-X.Y
branch, notmain
.)