RFC 24 implementation #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add to CLI
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
|
One todo, the warnings in cli currently present as errors |
cdisselkoen
reviewed
Feb 19, 2024
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
cdisselkoen
approved these changes
Feb 19, 2024
andrewmwells-amazon
approved these changes
Feb 19, 2024
| @@ -0,0 +1,28 @@ | |||
| /* | |||
| * Copyright 2022-2023 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
I believe Legal signed off on changing this to Copyright Cedar Contributors and removing the dates. If we don't want to do that yet, we should use 2024.
shaobo-he-aws
added a commit
that referenced
this pull request
Mar 4, 2024
`FromJsonError::UnescapeError`'s signature is reverted. Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implement RFC 24
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.