Moved (PolicyId as FromStr)::Err to Infallible
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdisselkoen
approved these changes
Jan 17, 2024
john-h-kastner-aws
approved these changes
Jan 17, 2024
|
@sarahcec I think this is the first breaking API change we've made since 3.0. Do we have somewhere we're tracking 4.0 changes? |
2 tasks
|
Tracking ticket for updating tinytodo: cedar-policy/cedar-examples#91 |
cdisselkoen
approved these changes
Jan 18, 2024
john-h-kastner-aws
added a commit
that referenced
this pull request
Feb 16, 2024
This reverts commit cfb5277.
john-h-kastner-aws
added a commit
that referenced
this pull request
Feb 19, 2024
This reverts commit cfb5277.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves the
FromStrimpl forPolicyIdto beInfallible, since it never returns an Error.Issue #, if available
551
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.