-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old integration testing code #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the size of the commit will make reviewing difficult. Here's the actual important part of the diff:
* [cedar-policy-core](./cedar-policy-core) : Internal crate containing the Cedar parser and evaluator
* [cedar-policy-validator](./cedar-policy-validator) : Internal crate containing the Cedar validator
* [cedar-policy-formatter](./cedar-policy-formatter) : Internal crate containing an auto-formatter for Cedar policies
-* [cedar-integration-tests](./cedar-integration-tests) : Crate containing integration tests
+* [cedar-testing](./cedar-testing) : Internal crate containing integration testing code
- Overhauled the FFI interface in the `frontend` module, and renamed it to
`ffi`; see #757. (#760, #793, #794, #800, #824, more coming)
- Much richer error information in the FFI interface (#800)
-- Deprecated the integration testing harness code. It will be removed from the
- `cedar-policy` crate in the next major version.
- Removed unnecessary lifetimes from some validation related structs (#715)
- Made `is_authorized` and `validate` functions in the frontend public, as well as their related structs: `AuthorizationAnswer`, `AuthorizationCall`, `Vali
dationCall`, `ValidationSettings`, `ValidationEnabled`, `ValidationError`, `ValidationWarning`, `ValidationAnswer`. (#737)
- Changed policy validation to reject comparisons and conditionals between
record types that differ in whether an attribute is required or optional.
+### Removed
+
+- Removed integration testing harness from the `cedar-policy` crate. It is now
+ in an internal crate, allowing us to make semver incompatible changes. (#857)
+
## [3.2.0] - Coming Soon
### Added
@@ -51,6 +54,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
report the precise source location where the unknown type was encountered.
Error for invalid use of an action now includes a source location containing
the offending policy. (#802, #808, resolving #522)
+- Deprecated the integration testing harness code. It will be removed from the
+ `cedar-policy` crate in the next major version. (#707)
heap-profiling = ["dep:dhat"]
corpus-timing = []
-integration_testing = []
-
# Experimental features.
# Enable all experimental features with `cargo build --features "experimental"`
experimental = ["partial-eval", "permissive-validate", "partial-validate"]
@@ -58,17 +56,6 @@ wasm = ["serde-wasm-bindgen", "tsify", "wasm-bindgen"]
crate_type = ["rlib", "cdylib"]
[dev-dependencies]
-# Hack to enable the `integration_testing` feature for the `Cedar` integration
-# tests without enabling it by default for ordinary consumers of `Cedar`. The
-# `default-features = false` stops this dependency from forcibly enabling the
-# default features of `Cedar`, leaving the default features to be controlled by
-# the ordinary `--no-default-features` flag of `cargo test`. See
-# https://github.com/rust-lang/cargo/issues/2911#issuecomment-1483256987 for
-# more information. That issue also tracks a real solution to the problem that
-# could replace this hack.
-cedar-policy = { path = ".", default-features = false, features = [
- "integration_testing",
-] }
cool_asserts = "2.0"
criterion = "0.5"
globset = "0.4"
mod prop_test_policy_set;
mod tests;
-
-#[cfg(feature = "integration_testing")]
-#[deprecated(since = "3.2.0", note = "please use the `cedar-testing` crate instead")]
-pub mod integration_testing; |
cdisselkoen
approved these changes
May 10, 2024
CI SemVer failure is expected. Downstream DRT failures are because we're (unnecessarily) depending on the |
john-h-kastner-aws
approved these changes
May 10, 2024
This was referenced May 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
cedar-integration-tests/
folder andcedar-policy/integration_testing.rs
file.Issue #, if available
Resolves #820
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):