Remove ParseErrors::errors_as_strings (fix #543)
#882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
changed the title
ParseErrors::errors_as_strings (fix #534)ParseErrors::errors_as_strings (fix #543)
2 tasks
aaronjeline
approved these changes
May 17, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There were three callers of this function in the wasm crate, but this function is simple enough that in lining it is not a problem. Possibly those calls should be updated to use rich information from miette. The callers might also be removed as part of #854.
Issue #, if available
#543
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
A breaking change requiring a major version bump to
cedar-policy(e.g., changes to the signature of an existing API).[ ]
I confirm that this PR (choose one, and delete the other options):
Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
I confirm that
cedar-spec(choose one, and delete the other options):