Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal ::new() with From/Into for EntityUid and EntityTypeName #993

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Replace internal ::new() with From/Into for EntityUid and EntityTypeName #993

merged 1 commit into from
Jun 19, 2024

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

I thought this would be more consistent with how we handle other internal/external pairs.

Not breaking, it only removes pub(crate) methods.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

@cdisselkoen cdisselkoen requested a review from khieta June 17, 2024 15:11
khieta
khieta approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, modulo fixes to CI (appears to be a cargo fmt issue?)

cedar-policy/src/api/id.rs Outdated Show resolved Hide resolved
@cdisselkoen cdisselkoen mentioned this pull request Jun 19, 2024
Merged
3 tasks
@cdisselkoen
Replace internal ::new() with From/Into for EntityUid and `En…
b04642a 
…tityTypeName`

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen force-pushed the cdisselkoen/into-entityuid branch from 0487558 to b04642a Compare June 19, 2024 20:02
@cdisselkoen
Copy link
Contributor Author

I think this is ready for re-review, and that the CI failures for DRT and Java are due to #983.

@cdisselkoen cdisselkoen merged commit 8980445 into main Jun 19, 2024
13 of 17 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/into-entityuid branch June 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khieta khieta khieta approved these changes

@shaobo-he-aws shaobo-he-aws shaobo-he-aws approved these changes

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdisselkoen @khieta @shaobo-he-aws @john-h-kastner-aws