Add contain_subset matcher #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjarratt
force-pushed
the
contain_subset_matcher
branch
from
4a0c9dc
to
a786ddd
Compare
This matcher can be used to check if a NSDictionary contains another NSDictionary as a subset.
tjarratt
force-pushed
the
contain_subset_matcher
branch
from
a786ddd
to
614ccaa
Compare
|
Just rebased this work on top of master, would love a second set of eyes on this once the build goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matcher can be used to check if a NSDictionary contains another NSDictionary as a subset.
We tried to clean up the implementation of
matchesas much as possible, but it was hard to keep the generic method that accepts any type and have overloaded implementations forNSDictionary *that don't need to do the validation. Perhaps someone has some feedback on how this could be done better?