Implement smarter KVC handling for class fakes #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancroom
force-pushed
the
kvc_improvements
branch
from
1df02dc
to
898090e
Compare
briancroom
force-pushed
the
kvc_improvements
branch
from
898090e
to
56b8c27
Compare
- valueForKey:/valueForKeyPath: handling - Superficially check for key validity
briancroom
force-pushed
the
kvc_improvements
branch
from
56b8c27
to
26872b3
Compare
|
👍 Thanks for driving this out and continuously soliciting feedback, @briancroom. This has been a painful feature, both from an implementor's perspective and the community's. |
tjarratt
added a commit
that referenced
this pull request
Jan 15, 2016
Implement smarter KVC handling for class fakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at addressing #355. I have confirmed with @pivotal-tom-mcneely that this patch does address the situation that prompted him to file the issue.
I tried not make the KVC implementation too smart. The
-valueForKey:implementation won't try to call into any other stubbed methods to retrieve a value for return. The main goal was to ensure that calling-valueForKey:won't simply throw an exception in cases where a real instance of the class wouldn't.