-
Notifications
You must be signed in to change notification settings - Fork 13
Remove unused test fixture: rsc-caching #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cedarjs canceled.
|
Co-authored-by: Tobbe <30793+Tobbe@users.noreply.github.com>
Co-authored-by: Tobbe <30793+Tobbe@users.noreply.github.com>
|
@copilot I've merged the latest changes from the |
Co-authored-by: Tobbe <30793+Tobbe@users.noreply.github.com>
Re-analysis complete after merging main (commit 0b9ea55). Current state: After the merge, 3 fixtures have been removed total:
Regarding example-todo-main-with-errors: It cannot be replaced with
All 16 test references specifically rely on these error conditions that don't exist in |
Investigated all fixtures in
__fixtures__/to identify unused projects that can be removed. After merging with main branch (which removedesm-fragment-test-projectandfragment-test-projectin PR #551), this PR removes the remaining unused fixture.Changes
rsc-caching(376K) - zero references in code, tests, CI/CD, or rebuild scripts__fixtures__/README.mddocumenting the 7 remaining fixtures, their purposes, CI/CD dependencies, and removal guidelinesexample-todo-main-with-errorscannot be replaced withexample-todo-mainCombined Results (with PR #551)
Total fixtures removed: 3
esm-fragment-test-project(1.1M) - removed in PR chore(ci): Remove unused projects from __fixtures__ #551 and this PRfragment-test-project(1.1M) - removed in PR chore(ci): Remove unused projects from __fixtures__ #551rsc-caching(376K) - removed in this PRTotal space saved: ~2.5MB
Analysis: example-todo-main-with-errors
This fixture cannot be replaced with
example-todo-mainbecause it contains unique error conditions that are specifically tested:All 16 test references specifically rely on these error conditions that don't exist in
example-todo-main.Remaining Fixtures
All 7 remaining fixtures are actively used:
Core infrastructure (high usage):
test-project- primary test fixture, used extensivelyexample-todo-main- 56+ references across packagesexample-todo-main-with-errors- 16 references for error testing (cannot be replaced)CI/CD dependencies:
test-project-rsa- RSC smoke tests workflowesm-test-project- ESM smoke tests workflowtest-project-rsc-kitchen-sink- RSC kitchen sink workflowSpecialized:
empty-project- minimal project path/config testsTotal: ~4.2MB across 7 fixtures
No further consolidation recommended - each serves a distinct testing purpose.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.