Fix ELM maxspeed parameter handling #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneuhauser
force-pushed
the
fix-elm-maxspeed
branch
from
68aa749
to
0a08dbb
Compare
fixes: cc944b5: Possibility to choose baudrate At least if you choose bluetooth as connection type, `raise_port_speed` in `portChooser` gets unset instead of "No" or a valid baudrate and causes trouble in the init function of the `ELM` class. Fix this with a simple try except combo and adapt the following conditions on maxspeed.
jneuhauser
force-pushed
the
fix-elm-maxspeed
branch
from
0a08dbb
to
e64c3bc
Compare
cedricp
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least if you choose bluetooth as connection type,
raise_port_speedinportChoosergets unset instead of "No" or a valid baudrate and causes trouble in the init function of theELMclass.Fix this with a simple try except combo and adapt the following conditions on maxspeed.
Additionally add a proper gitignore file. Feel free to drop this...