Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dump snat/dnat - update elm.py referencies #963

Merged
merged 23 commits into from
Dec 22, 2023
Merged

add dump snat/dnat - update elm.py referencies #963

merged 23 commits into from
Dec 22, 2023

Conversation

Furtif
Copy link
Collaborator

@Furtif Furtif commented Dec 16, 2023

Notes:

@Furtif Furtif requested a review from cedricp December 16, 2023 18:57
@Furtif Furtif changed the title add dump snat/dnat add dump snat/dnat - update elm.py referencies Dec 16, 2023
@shrlnm
Copy link
Contributor

shrlnm commented Dec 19, 2023

Hello @Furtif
dnat/snat tables have a number of conflicting records for different platforms. The pyren use these tables only in cases where the platform is unknown. If you do not mind I include not conflicting records in mod_elm.py.

Whenever it is possible the pyren uses CANid from platform files.

In CLIP mode it uses Vehicles/TCOM* files

In DDT mode it uses DDT2000data/vehicles/Projects.xml
it loads "projects/Manufacturer/project/addressing" field and loads addressing from referred file

@Furtif
Copy link
Collaborator Author

Furtif commented Dec 19, 2023

Hello @Furtif dnat/snat tables have a number of conflicting records for different platforms. The pyren use these tables only in cases where the platform is unknown. If you do not mind I include not conflicting records in mod_elm.py.

Whenever it is possible the pyren uses CANid from platform files.

In CLIP mode it uses Vehicles/TCOM* files

In DDT mode it uses DDT2000data/vehicles/Projects.xml it loads "projects/Manufacturer/project/addressing" field and loads addressing from referred file

yes this is the best way but now I scanned all addressings.xml and regrouped them all https://github.com/cedricp/ddt4all/pull/963/files#diff-89b986fb120d6829b663b7fcfc98a5b7a4326150cf058c4a8695c4982721a623R1947

@Furtif
Copy link
Collaborator Author

Furtif commented Dec 21, 2023

@shrlnm better as 669e97f ?

@Furtif Furtif removed the request for review from cedricp December 21, 2023 21:32
@Furtif Furtif merged commit 5806689 into master Dec 22, 2023
1 check passed
@Furtif Furtif deleted the add_dump branch December 22, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants