Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README.md and example #244

Closed
wants to merge 2 commits into from
Closed

update README.md and example #244

wants to merge 2 commits into from

Conversation

rashidotm
Copy link

this pr is to update code samples in readme and in exmaple

@rashidotm
Copy link
Author

this fixes #241

@cedvdb
Copy link
Owner

cedvdb commented Apr 29, 2024

Thanks for your contribution. I'm confused why the example compiled and was uploaded to github page if it was erroneous like that

@cedvdb
Copy link
Owner

cedvdb commented Apr 29, 2024

The build is now failing. It seems like you are using an old version in example or something. If you check the validation code for example, they all take a context but you removed the context:

https://github.com/cedvdb/phone_form_field/blob/main/lib/src/validation/phone_validator.dart#L55

@rashidotm
Copy link
Author

This is embarrassing!

You are right. I was using an old version and haven't noticed till you pointed it out.

@rashidotm
Copy link
Author

closing this as the version used was not latest.

@rashidotm rashidotm closed this Apr 29, 2024
@cedvdb
Copy link
Owner

cedvdb commented Apr 30, 2024

@rashidotm did you clone the repository a long time ago ? I'm wondering if something needs changing in the lock file or something or if it's just due to not pulling

@rashidotm
Copy link
Author

it is not you, it is me.

I did clone the repo this week. but when I tried the example my mistake was that I copied it into a fresh flutter project. my flutter version was old and hence pub get auto resolved to an older version of this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants