Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining unit tests #7

Merged

Commits on Apr 28, 2020

  1. Configuration menu
    Copy the full SHA
    5ec359e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Update generate_breadcrumbs test

    - add test suite for generateBreadcrumb() itself (in order to cover a missing branch)
    - minor lint fixes
    - remove unnecessary import from set_breadcrumbs test
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ab467f4 View commit details
    Browse the repository at this point in the history
  2. Write test for get_username util

    + update test to return a more consistent falsey value (null)
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    578de16 View commit details
    Browse the repository at this point in the history
  3. Add test for SetupGuide

    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    500533e View commit details
    Browse the repository at this point in the history
  4. [Refactor] Pull out various Kibana context mocks into separate files

    - I'm creating a reusable useContext mock for shallow()ed enzyme components
    + add more documentation comments + examples
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    634ae14 View commit details
    Browse the repository at this point in the history
  5. Write tests for empty state components

    + test new usecontext shallow mock
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    279b267 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48cf48a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    afa53e6 View commit details
    Browse the repository at this point in the history
  8. Write tests for engine overview table

    + fix bonus bug
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    3e2a867 View commit details
    Browse the repository at this point in the history
  9. Write Engine Overview tests

    + Update EngineOverview logic to account for issues found during tests :)
      - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s)
      - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno)
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    6b78743 View commit details
    Browse the repository at this point in the history
  10. Refactor EngineOverviewHeader test to use shallow + to full coverage

    - missed adding this test during telemetry work
    - switching to shallow and beforeAll reduces the test time from 5s to 4s!
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    077b1e1 View commit details
    Browse the repository at this point in the history
  11. [Refactor] Pull out React Router history mocks into a test util helper

    + minor refactors/updates
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    8d25b05 View commit details
    Browse the repository at this point in the history
  12. Add small tests to increase branch coverage

    - mostly testing fallbacks or removing fallbacks in favor of strict type interface
    - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable
    cee-chen committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    38d07db View commit details
    Browse the repository at this point in the history