-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement remaining unit tests #7
Implement remaining unit tests #7
Commits on Apr 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5ec359e - Browse repository at this point
Copy the full SHA 5ec359eView commit details
Commits on Apr 30, 2020
-
Update generate_breadcrumbs test
- add test suite for generateBreadcrumb() itself (in order to cover a missing branch) - minor lint fixes - remove unnecessary import from set_breadcrumbs test
Configuration menu - View commit details
-
Copy full SHA for ab467f4 - Browse repository at this point
Copy the full SHA ab467f4View commit details -
Write test for get_username util
+ update test to return a more consistent falsey value (null)
Configuration menu - View commit details
-
Copy full SHA for 578de16 - Browse repository at this point
Copy the full SHA 578de16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 500533e - Browse repository at this point
Copy the full SHA 500533eView commit details -
[Refactor] Pull out various Kibana context mocks into separate files
- I'm creating a reusable useContext mock for shallow()ed enzyme components + add more documentation comments + examples
Configuration menu - View commit details
-
Copy full SHA for 634ae14 - Browse repository at this point
Copy the full SHA 634ae14View commit details -
Write tests for empty state components
+ test new usecontext shallow mock
Configuration menu - View commit details
-
Copy full SHA for 279b267 - Browse repository at this point
Copy the full SHA 279b267View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48cf48a - Browse repository at this point
Copy the full SHA 48cf48aView commit details -
Configuration menu - View commit details
-
Copy full SHA for afa53e6 - Browse repository at this point
Copy the full SHA afa53e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e2a867 - Browse repository at this point
Copy the full SHA 3e2a867View commit details -
+ Update EngineOverview logic to account for issues found during tests :) - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s) - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno)
Configuration menu - View commit details
-
Copy full SHA for 6b78743 - Browse repository at this point
Copy the full SHA 6b78743View commit details -
Refactor EngineOverviewHeader test to use shallow + to full coverage
- missed adding this test during telemetry work - switching to shallow and beforeAll reduces the test time from 5s to 4s!
Configuration menu - View commit details
-
Copy full SHA for 077b1e1 - Browse repository at this point
Copy the full SHA 077b1e1View commit details -
[Refactor] Pull out React Router history mocks into a test util helper
+ minor refactors/updates
Configuration menu - View commit details
-
Copy full SHA for 8d25b05 - Browse repository at this point
Copy the full SHA 8d25b05View commit details -
Add small tests to increase branch coverage
- mostly testing fallbacks or removing fallbacks in favor of strict type interface - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable
Configuration menu - View commit details
-
Copy full SHA for 38d07db - Browse repository at this point
Copy the full SHA 38d07dbView commit details