Add error logging for CefApp::OnRegisterCustomSchemes

cefsharp · May 8, 2017 · 79b5a8e · 79b5a8e
1 parent c8d0127
commit 79b5a8e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/CefSharp.Core/Internals/CefSharpApp.h b/CefSharp.Core/Internals/CefSharpApp.h
@@ -117,8 +117,13 @@ namespace CefSharp
         {
             for each (CefCustomScheme^ scheme in _cefSettings->CefCustomSchemes)
             {
-                // TOOD: Consider adding error handling here. But where do we report any errors that may have occurred?
-                registrar->AddCustomScheme(StringUtils::ToNative(scheme->SchemeName), scheme->IsStandard, scheme->IsLocal, scheme->IsDisplayIsolated, scheme->IsSecure, scheme->IsCorsEnabled, false);
+                auto success = registrar->AddCustomScheme(StringUtils::ToNative(scheme->SchemeName), scheme->IsStandard, scheme->IsLocal, scheme->IsDisplayIsolated, scheme->IsSecure, scheme->IsCorsEnabled, false);
+
+                if (!success)
+                {
+                    String^ msg = "CefSchemeRegistrar::AddCustomScheme failed for schemeName:" + scheme->SchemeName;
+                    LOG(ERROR) << StringUtils::ToNative(msg).ToString();
+                }
             }
         };