Pevent merging of repeated values in headerMap when using custom handlers #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Aug 28, 2017
| @@ -237,4 +237,4 @@ namespace CefSharp | |||
| } | |||
| }; | |||
| } | |||
| } | |||
merceyz
reviewed
Aug 28, 2017
| @@ -1,4 +1,4 @@ | |||
| // Copyright � 2010-2017 The CefSharp Authors. All rights reserved. | |||
| // Copyright © 2010-2017 The CefSharp Authors. All rights reserved. | |||
merceyz
reviewed
Aug 28, 2017
| String^ value = headers[key]; | ||
| result.insert(std::pair<CefString, CefString>(StringUtils::ToNative(key), StringUtils::ToNative(value))); | ||
| for each(String^ value in headers->GetValues(key)) | ||
| result.insert(std::pair<CefString, CefString>(StringUtils::ToNative(key), StringUtils::ToNative(value))); |
There was a problem hiding this comment.
Braces around the body of the loop please
|
Made some comments inline |
…s under the same key, with ",". This breaks some headers, like the "Set-Cookie"; where the "." has another meanings according to RFC.
|
requested changes done. |
|
thanks @merceyz for your feedback. i've made the changes you reviewed. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NameValueCollection auto merges (according to MSDN) all the values under the same key, with ",".
This breaks some headers, like the "Set-Cookie"; where the "." has another meanings according to RFC.
as far as i've seen, this issue will be present everytime a customhandler is used.