Update to Cef Version 59.0.0 #2114

GrabzIt · 2017-08-18T14:46:03Z

Note that there is one breaking change as offscreen windows are now automatically transparent due to this cef change: https://bitbucket.org/chromiumembedded/cef/commits/3f71138d64586d774f645a6db5283b5205ea9df4

To make a offscreen window non-transparent you need to set the background colour as shown below were it is set to white:

browserSettings.BackgroundColor = 0255255255;

Note that there is one breaking change as offscreen windows are now automatically transparent due to this cef change: https://bitbucket.org/chromiumembedded/cef/commits/3f71138d64586d774f645a6db5283b5205ea9df4 To make a offscreen window non-transparent you need to set the background colour as shown below were it is set to white: browserSettings.BackgroundColor = 0255255255;

GrabzIt · 2017-08-18T20:01:33Z

This will require the cef version in appveyor to be updated to 3.3071.1649

ipoweb · 2017-10-05T08:40:04Z

any news about this update ?

amaitland · 2017-10-05T23:37:40Z

CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj

  </ItemGroup>
  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
  <ImportGroup Label="ExtensionTargets" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">


The EnsureNuGetPackageBuildImports targets need to be removed from this file and the others.

See the following for background
http://blog.davidebbo.com/2014/01/the-right-way-to-restore-nuget-packages.html
https://www.xavierdecoster.com/post/2014/03/06/migrate-away-from-msbuild-based-nuget-package-restore.html

amaitland · 2017-10-05T23:44:35Z

build.ps1

@@ -1,11 +1,11 @@
 param(
    [ValidateSet("vs2013", "vs2015", "nupkg-only", "gitlink")]
    [Parameter(Position = 0)] 
-    [string] $Target = "vs2013",
+    [string] $Target = "vs2015",


Are you deliberately upgrading the project to VC++ 2015? The documentation would need to be updated if this is the path your planning on taking, See #1983 the previous discussion on the topic.

Sorry, no I wasn't I just compiled it in 2015. I will fix the target.

amaitland · 2017-10-05T23:49:28Z

CefSharp.Core/ManagedCefBrowserAdapter.cpp

@@ -78,7 +77,7 @@ void ManagedCefBrowserAdapter::CreateBrowser(BrowserSettings^ browserSettings, R
    CefString addressNative = StringUtils::ToNative(address);

    CefBrowserHost::CreateBrowser(window, _clientAdapter.get(), addressNative,
-        *browserSettings->_browserSettings, requestContext);
+        *browserSettings->_browserSettings, *requestContext);


Was there an actual compiler error or were you just going by the Intellisense warning that there was a problem? The intellisense warning is safe to ignore.

As it's a ref counted pointer, I'd suggest changing this to static_cast<CefRefPtr<CefRequestContext>>(requestContext) instead. Passing in as a pointer should be safe in this instance, in general you shouldn't pass a ref counted pointer around as a normal pointer.

Will do I will need to read up on the difference.

https://bitbucket.org/chromiumembedded/cef/wiki/GeneralUsage.md#markdown-header-reference-counting
https://www.chromium.org/developers/smart-pointer-guidelines

amaitland · 2017-10-05T23:53:01Z

This will require the cef version in appveyor to be updated to 3.3071.1649

@GrabzIt If you tag a release on the cef-binary project following the same structure as the others appveyor will build and upload packages to Myget.

Few passing comments made inline, best of luck 👍

amaitland · 2017-10-05T23:54:50Z

any news about this update ?

Further releases are blocked on #1203

At this rate it's looking like you'll have to wait for Chromium to re-add support for the Process Per Tab process model.

GrabzIt · 2017-10-06T05:51:47Z

Hi @amaitland I will make the changes. However someone raised the possibility of #1562 or fixing the blocking issue. What do you think?

amaitland · 2017-10-06T06:21:36Z

However someone raised the possibility of #1562 or fixing the blocking issue. What do you think?

I find it very unlikely, you should investigate for yourself.

GrabzIt · 2017-10-06T07:15:20Z

I ended up moving to the async javascript objects which doesn't have the issue. The code has been in production for a month so far with no problems.

GrabzIt · 2017-10-06T07:28:51Z

Thanks for all the background information. I have made the requested changes.

amaitland · 2017-10-06T07:45:29Z

I ended up moving to the async javascript objects which doesn't have the issue. The code has been in production for a month so far with no problems.

The problem described in #1203 affects both sync and async versions. They share the same code for large parts.

amaitland · 2017-10-06T07:47:12Z

CefSharp.Core/Internals/CefBrowserHostWrapper.cpp

@@ -20,7 +20,7 @@ void CefBrowserHostWrapper::DragTargetDragEnter(IDragData^ dragData, MouseEvent

    auto dragDataWrapper = static_cast<CefDragDataWrapper^>(dragData);
    dragDataWrapper->ResetFileContents(); // Recommended by documentation to reset before calling DragEnter
-    _browserHost->DragTargetDragEnter(dragDataWrapper, GetCefMouseEvent(mouseEvent), (CefBrowserHost::DragOperationsMask) allowedOperations);
+    _browserHost->DragTargetDragEnter(*dragDataWrapper, GetCefMouseEvent(mouseEvent), (CefBrowserHost::DragOperationsMask) allowedOperations);


This pointer reference should also be changed.

GrabzIt · 2017-10-06T08:06:12Z

The problem described in #1203 affects both sync and async versions. They share the same code for large parts.
It may be because my browser instances are so short lived that I am getting away with it.

I have updated the pointer in the mouse drag code as requested.

amaitland · 2017-10-06T08:27:27Z

It may be because my browser instances are so short lived that I am getting away with it.

More like your navigating to websites within the same domain???

GrabzIt · 2017-10-06T08:37:21Z

More like your navigating to websites within the same domain???

Actually I had exactly that problem! On my US servers calls to www.bbc.co.uk would go to www.bbc.com and break. It took two days of working on the issue, but I eventually read this case #1782 where he said he had a similar issue with losing registered objects and switched to async and that fixed his issue.

So I converted all of my C# JavaScript calls to use the async methods and made all of my JavaScript async as well (using let and async keywords etc) and it worked. I haven't had anymore of those problems.

amaitland · 2017-10-06T08:47:32Z

Actually I had exactly that problem!

And your using a version greater than 57? In versions greater if the browser process switches to a new sub process, the bound objects are never registered in the new process.. The sync and async versions use the same code to transmit the objects, unless ClientAdapter::OnRenderViewReady is now being called for the creation of every process then it's not possible for one to work and the other to be broken. It maybe possible with a newer Chromium version the process switching is less aggressive and your domains aren't spawning a new process.

CefSharp/CefSharp.Core/Internals/ClientAdapter.cpp

Line 562 in d168116

if (objectRepository->HasBoundObjects)

GrabzIt · 2017-10-06T08:52:56Z

Oh ok, maybe that is what it is. I am now using version 60, but the fix also worked on version 59.

amaitland · 2017-10-06T09:19:55Z

Oh ok, maybe that is what it is. I am now using version 60, but the fix also worked on version 59.

Tried your new branch and still breaks as expected, even using bbc.co.uk and then navigating to bbc.com the render process switches and the bound objects are no longer available. Unclear what your doing differently,

Anyways, I've spent way more time than I was planning on this, so that's it from me for now. I'll check back in a few months (probably when I have time off over Christmas). Best of luck getting a release out 👍

GrabzIt · 2017-10-06T09:36:36Z

Thanks for all your help! You are a legend!

I am not sure why it is working on my version. One possibility is that I am setting the --renderer-process-limit to 1. So maybe that is related.

I haven't made any more changes to the cefsharp code to handle it though. I will keep an eye on the #1203 case and release when it is fixed. You are right it is better to be safe than breaking everyone's projects!

GrabzIt added 3 commits August 18, 2017 15:45

Updated to version 59.0.0

08444fe

Updated version 59.0.0 to latest build 3.3071.1649

2f680f0

amaitland reviewed Oct 5, 2017

View reviewed changes

GrabzIt added 6 commits October 6, 2017 08:03

Removed EnsureNuGetPackageBuildImports

ea7d2c8

Remove EnsureNuGetPackageBuildImports target

3d45c10

Removed EnsureNuGetPackageBuildImports

b5ade51

Removed EnsureNuGetPackageBuildImports

22b67f0

Removed EnsureNuGetPackageBuildImports

fb5a0bb

Put target back to 2013

f82d744

Fixed pointer

62ae9ed

amaitland reviewed Oct 6, 2017

View reviewed changes

Updated pointer

f76f4d9

cztomczak mentioned this pull request Oct 7, 2017

Update to Chromium v61 cztomczak/cefpython#397

Closed

GrabzIt merged commit 653896a into cefsharp:master Oct 7, 2017

cztomczak mentioned this pull request Oct 28, 2017

Update to Chromium v66 cztomczak/cefpython#403

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Cef Version 59.0.0 #2114

Update to Cef Version 59.0.0 #2114

GrabzIt commented Aug 18, 2017

GrabzIt commented Aug 18, 2017

ipoweb commented Oct 5, 2017

amaitland Oct 5, 2017

amaitland Oct 5, 2017

GrabzIt Oct 6, 2017

amaitland Oct 5, 2017

GrabzIt Oct 6, 2017

amaitland Oct 6, 2017

amaitland commented Oct 5, 2017

amaitland commented Oct 5, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

amaitland Oct 6, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017 •

edited

Loading

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

Update to Cef Version 59.0.0 #2114

Update to Cef Version 59.0.0 #2114

Conversation

GrabzIt commented Aug 18, 2017

GrabzIt commented Aug 18, 2017

ipoweb commented Oct 5, 2017

amaitland Oct 5, 2017

Choose a reason for hiding this comment

amaitland Oct 5, 2017

Choose a reason for hiding this comment

GrabzIt Oct 6, 2017

Choose a reason for hiding this comment

amaitland Oct 5, 2017

Choose a reason for hiding this comment

GrabzIt Oct 6, 2017

Choose a reason for hiding this comment

amaitland Oct 6, 2017

Choose a reason for hiding this comment

amaitland commented Oct 5, 2017

amaitland commented Oct 5, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

amaitland Oct 6, 2017

Choose a reason for hiding this comment

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017 • edited Loading

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

amaitland commented Oct 6, 2017

GrabzIt commented Oct 6, 2017

GrabzIt commented Oct 6, 2017 •

edited

Loading