VS2017 build support (using the VS2015 tooling) #2179
Conversation
apparently http://nuget.org/nuget.exe is version 2.8, which is fairly old
There was a problem hiding this comment.
Thanks a lot for this! 👏 👏 👏 Awesome fix, I tested this on my local VS2015 and VS2017 now and it seems to work fine. The best part about is that it does not break VS2013 (but we probably want to drop it sooner or later, once no-one demands support for it any more.)
(If/when we change the AppVeyor builds from VS2013, we probably have to distribute both VC++2013 and 2015 redist, which is a pain in the neck, so we should recompile the cef-binary wrapper with VS2015 if/when that hapens.)
VC++2017(v141) is compatible with VC++2015(v140), which enables us to use the v141 toolset to compile against the v140 libcef_dll_wrapper.lib - not necessary to install the VC++2015 compiler as part of a clean VS2017 install Follow up to #2179
|
Changed to target |
|
|
Corrected VisualStudioProductVersion
note: I redid the pull request for a more clean version.
Added support for VS2017, using the VS2015 toolset (use the VS2017 installer to install this toolset).
I also added a config file for the "Microsoft Child Process Debugging Power Tool" which will allow automatic debugging of child processes.
I updated the nuget url, since appveyor could not install xunit.abstractions 2.0.1 with the old nuget.
I extracted the PostBuild script into the CefSharp.props file and tried to keep the behaviour the same for non-VS2017 (however, I cannot test that without VS2013 and VS2015, but it succeeds on appveyor).
Note though that the CefSharp.Test OffScreenBrowserBasicFacts tests are failing and I am unsure if that is expected (since they were only recently added and I don't see a succesfull appveyor build yet).