Fixes ownership issue on Ubuntu (voxpupuli#157)

* "On Ubuntu 14.04, redis has an init script that does chown redis:redis $RUNDIR $PIDFILE (where RUNDIR=/var/run/redis and PIDFILE=$RUNDIR/redis-server.pid) at startup. This causes puppet to "fix" the ownership of /var/run/redis (to redis:root unless config_owner and config_group have been set differently), which triggers a restart of redis-server, which changes the ownership of /var/run/redis, etc. forever. * Closes voxpupuli#150
cegeka · Apr 12, 2017 · 67d75b3 · 67d75b3
1 parent 6ec63b1
commit 67d75b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/manifests/params.pp b/manifests/params.pp
@@ -103,7 +103,7 @@
       $config_file               = '/etc/redis/redis.conf'
       $config_file_mode          = '0644'
       $config_file_orig          = '/etc/redis/redis.conf.puppet'
-      $config_group              = 'root'
+
       $config_owner              = 'redis'
       $daemonize                 = true
       $log_dir_mode              = '0755'
@@ -130,10 +130,12 @@
 
       case $::operatingsystem {
         'Ubuntu': {
+          $config_group              = 'redis'
           # Latest from PPA is 3.0.7
           $minimum_version           = '3.0.7'
         }
         default: {
+          $config_group              = 'root'
           # Debian standard package is 2.4.14
           # But we have dotdeb repo which is 3.2.5
           $minimum_version           = '3.2.5'

diff --git a/spec/classes/redis_spec.rb b/spec/classes/redis_spec.rb
@@ -54,7 +54,7 @@
             is_expected.to contain_file('/var/run/redis').with({
               :ensure => 'directory',
               :owner  => 'redis',
-              :group  => 'root',
+              :group  => 'redis',
               :mode   => '0755',
             })
           end