Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors with GEANT4 11.2.0 #1074

Closed
smuzaffar opened this issue Dec 28, 2023 · 2 comments · Fixed by #1075
Closed

Build errors with GEANT4 11.2.0 #1074

smuzaffar opened this issue Dec 28, 2023 · 2 comments · Fixed by #1075
Labels
bug Something isn't working external Dependencies and framework-oriented features

Comments

@smuzaffar
Copy link

Hi,
Looks like celeritas v0.4.1 or latest devel branch failed to build with Geant 11.2.0. The build error I get is [a]

In file included from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4TouchableHandle.hh:42,
                 from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4StepPoint.hh:47,
                 from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4Step.hh:53,
                 from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4VParticleChange.hh:65,
                 from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4VProcess.hh:48,
                 from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4Transportation.hh:46,
                 from <path>/celeritas/src/celeritas/ext/GeantGeoParams.cc:14:
<path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4VTouchable.hh:39:7: error: conflicting declaration 'using G4VTouchable = class G4TouchableHistory'
   39 | using G4VTouchable = G4TouchableHistory;
      |       ^~~~~~~~~~~~
In file included from <path>/celeritas/src/celeritas/ext/GeantGeoData.hh:18,
                 from <path>/celeritas/src/celeritas/ext/GeantGeoParams.hh:19,
                 from <path>/celeritas/src/celeritas/ext/GeantGeoParams.cc:8:
<path>/celeritas/src/celeritas/ext/detail/GeantGeoNavCollection.hh:20:7: note: previous declaration as 'class G4VTouchable'
   20 | class G4VTouchable;
      |       ^~~~~~~~~~~~
In file included from <path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4StepPoint.hh:191:
<path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4StepPoint.icc: In member function 'G4VPhysicalVolume* G4StepPoint::GetPhysicalVolume() const':
<path>/geant4/11.2.0-369aba6a4851f900c7e85d3309525223/include/Geant4/G4StepPoint.icc:158:21: error: invalid use of incomplete type 'class G4VTouchable'
  158 |   return fpTouchable->GetVolume();
      |                     ^~
<path>/celeritas/src/celeritas/ext/detail/GeantGeoNavCollection.hh:20:7: note: forward declaration of 'class G4VTouchable'
   20 | class G4VTouchable;
@sethrj sethrj added bug Something isn't working external Dependencies and framework-oriented features labels Dec 28, 2023
@sethrj
Copy link
Member

sethrj commented Dec 28, 2023

Thanks @smuzaffar . This error looks like a simple IWYU but we'll make sure everything builds as expected first... and we'll try to be more on top of the Geant4 releases in the future now that we have downstream dependents!

@whokion
Copy link
Contributor

whokion commented Dec 28, 2023

Following up with MR, #1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Dependencies and framework-oriented features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants