-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Geant4@11.2 #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @whokion ! But these changes need to be guarded with G4VERSION macros (there are examples elsewhere) so that it still works all the way back to Geant4 10.5...
As far as I can see, these updates should be good for 10.5 and later without the version guard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a somewhat hacky CELERITAS_GEANT4_VERSION
version macro via the celeritas_sys_config
which doesn't require anything downstream to link against geant4. So this now builds on 11.0 and 11.2.
I'm still having trouble getting this to work at runtime with geant4 11.2. Trying to setup the photoelectric model gives:
G4EMLOW8.5 exists but epics2017 doesn't! Looks like this could be related to geant4 change |
Odd, I do see the data in |
OK, somehow it looks like EMLOW 6.5 got aliased into my 8.5 directory... weird! |
Updates for Geant4 11.2
Description
This MR updates compatibility of celeritas to the new version of Geant4 11.2
Fixes #1074