Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile-time consistency check for Celeritas and Geant4 versions #1123

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Feb 22, 2024

Follow-on to #1075: this puts a check in the .cc file that compares the Geant4-reported version number (<G4Version.hh>) from the one stored by Celeritas gleaned from the CMake-reported Geant4 version (celeritas_sys_config.h).

@sethrj sethrj added minor Minor internal changes or fixes external Dependencies and framework-oriented features labels Feb 22, 2024
@sethrj sethrj requested a review from pcanal February 22, 2024 22:49
@sethrj sethrj enabled auto-merge (squash) February 23, 2024 19:25
@sethrj sethrj merged commit 8230b45 into celeritas-project:develop Feb 23, 2024
20 of 21 checks passed
@sethrj sethrj deleted the geant4-version-check branch March 7, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Dependencies and framework-oriented features minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants