Add ORANGE surface construction components #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
elliottbiondo
approved these changes
Nov 2, 2023
| * id. | ||
| * | ||
| * The second case adds the surface so that multiple nearby surfaces can be | ||
| * \em chained together, even if the tolerance between the furthest apart is |
There was a problem hiding this comment.
I understand the purpose of the em-dashes above, but not in this paragraph.
There was a problem hiding this comment.
The em is the <em> html tag aka "emphasis" (i.e., italicized).
| inline LocalSurfaceId operator()(S const& surface); | ||
|
|
||
| private: | ||
| using MapSurfId = std::unordered_map<LocalSurfaceId, LocalSurfaceId>; |
There was a problem hiding this comment.
>>> TYPES, >>> HELPER FUNCTIONS, >>> DATA for consistency, but not necessary
src/orange/surf/FaceNamer.cc
Outdated
|
|
||
| //---------------------------------------------------------------------------// | ||
| /*! | ||
| * Construct a name for a sphere. |
| /*! | ||
| * Construct a name for a sphere. | ||
| */ | ||
| std::string FaceNamer::Impl::operator()(Sphere const&) const |
There was a problem hiding this comment.
Are sphere and centered sphere supposed to have the same name?
There was a problem hiding this comment.
Yeah, that's how it is in the current SCALE builder. I can't think of any shape that has anything but a single sphere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two classes necessary for constructing surfaces from shapes:
LocalSurfaceInserterwhich deduplicates surfaces, including chaining nearly-adjacent surfaces (see test) which is something the SCALE ORANGE fails to doFaceNamerwhich constructs surface extensions (e.g.px,p1,s) to be combined with shape names to form surface namesCurrently inserting N surfaces with deduplication is an
O(N^2)operation because the initial implementation does not use hashing to reduce the number of surfaces needed to test. However, in opt mode (on my laptop) 32k surface insertions take under a second, and a debug build takes just over a second to do 8k surfaces.