Add G4SD "simple calorimeter" that outputs to JSON #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
force-pushed
the
geant-simple-calo
branch
from
1065ed8 to
ed3dfce
Compare
sethrj
force-pushed
the
geant-simple-calo
branch
from
ed3dfce to
1b5b5ce
Compare
|
@amandalund This is finally ready for review. |
amandalund
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Nice, this look great @sethrj! I tried it (and the Celeritas simple calo) out with testem3 and the results look like we expect:
Co-authored-by: Amanda Lund <alund@anl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "simple calorimeter" (event and thread integrated, differential per logical volume) detector that saves its output to JSON in the same format as the on-GPU calorimeters. This will let us do an accurate comparison of the cost for converting hits through the Geant4 layer versus directly storing on GPU.