Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link errors in edge cases and restore HIP testing #1042

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Fix link errors in edge cases and restore HIP testing #1042

merged 8 commits into from
Jan 23, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 1, 2023 •
edited
Loading

#1038 had to disable HIP to get jenkins working because of problems with the runners. This:

  • restores the HIP runtime execution
  • adds a warning about the inability to link to static celeritas built against HIP (I think due to a downstream cmake bug)
  • fixes linking a non-CUDA Celeritas against a CUDA-enabled VecGeom (@hhollenb )

@sethrj sethrj added core Software engineering infrastructure minor Minor internal changes or fixes labels Dec 1, 2023
@sethrj
Copy link
Member Author

sethrj commented Dec 1, 2023

@Rombur would you mind pinging me here or on Teams when the ROCm runners are fixed? It's not urgent. Thanks for getting the CUDA runners back online!

(Current failing HIP build)

@Rombur
Copy link

Rombur commented Dec 1, 2023

Sure

@sethrj sethrj marked this pull request as ready for review December 14, 2023 10:14
@sethrj sethrj marked this pull request as draft December 14, 2023 10:15
@sethrj
Copy link
Member Author

sethrj commented Dec 14, 2023

Still broken...

@Rombur
Copy link

Rombur commented Jan 22, 2024

The AMD machines are back online

@sethrj sethrj marked this pull request as ready for review January 22, 2024 18:33
@sethrj sethrj changed the title Restore HIP builds in Jenkins CI Fix link errors in edge cases and restore HIP testing Jan 22, 2024
@sethrj sethrj mentioned this pull request Jan 22, 2024
Merged
@sethrj sethrj marked this pull request as draft January 23, 2024 13:46
@sethrj sethrj marked this pull request as ready for review January 23, 2024 14:47
@sethrj sethrj force-pushed the restore-jenkins-hip branch from 3fae135 to e36c47d Compare January 23, 2024 16:21
@sethrj sethrj requested a review from amandalund January 23, 2024 16:40
amandalund
amandalund approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sethrj!

@sethrj sethrj enabled auto-merge (squash) January 23, 2024 18:35
@sethrj sethrj merged commit d77519b into celeritas-project:develop Jan 23, 2024
19 of 20 checks passed
sethrj added a commit that referenced this pull request Jan 23, 2024
@sethrj
Fix link errors in edge cases and restore HIP testing (#1042)
d215b0a
@sethrj sethrj deleted the restore-jenkins-hip branch January 23, 2024 21:32
sethrj added a commit that referenced this pull request Feb 15, 2024
@sethrj
Fix link errors in edge cases and restore HIP testing (#1042)
c09d897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandalund amandalund amandalund approved these changes

Assignees
No one assigned
Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethrj @Rombur @amandalund