Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jump ahead for XORWOW RNG #1049

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

amandalund
Copy link
Contributor

This lets us initialize the XORWOW RNG with a subsequence and an offset to skip ahead in the stream. The jump ahead method is implemented using the polynomial representation of the recurrence, which requires less memory than the jump matrices. The jump polynomials are precalculated and can be generated using a script in the utils repo.

@amandalund amandalund added enhancement New feature or request core Software engineering infrastructure labels Dec 5, 2023
@amandalund amandalund requested a review from sethrj December 5, 2023 20:54
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of clarifications.

src/celeritas/random/XorwowRngEngine.hh Outdated Show resolved Hide resolved
src/celeritas/random/XorwowRngEngine.hh Outdated Show resolved Hide resolved
src/celeritas/random/XorwowRngData.hh Outdated Show resolved Hide resolved
src/celeritas/random/CuHipRngEngine.hh Outdated Show resolved Hide resolved
src/celeritas/random/XorwowRngEngine.hh Outdated Show resolved Hide resolved
src/celeritas/random/XorwowRngEngine.hh Outdated Show resolved Hide resolved
test/celeritas/random/XorwowRngEngine.test.cc Show resolved Hide resolved
test/celeritas/random/XorwowRngEngine.test.cc Outdated Show resolved Hide resolved
@sethrj sethrj enabled auto-merge (squash) December 7, 2023 11:34
@sethrj sethrj merged commit e3610f9 into celeritas-project:develop Dec 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants