Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROOT dictionary paths #1054

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix ROOT dictionary paths #1054

merged 2 commits into from
Dec 7, 2023

Conversation

pcanal
Copy link
Contributor

@pcanal pcanal commented Dec 7, 2023

This allows to run code requiring the dictionary (eg. celer-sim) from the install directory (and when the source is not accessible)

In addition explicit include <unistd.h> for process id.

@sethrj sethrj added bug Something isn't working external Dependencies and framework-oriented features labels Dec 7, 2023
@sethrj sethrj changed the title Do not record full pathname in ROOT Dictionary Fix ROOT dictionary paths Dec 7, 2023
@pcanal pcanal requested a review from sethrj December 7, 2023 15:49
@pcanal pcanal self-assigned this Dec 7, 2023
sethrj
sethrj approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ROOT. Thanks @pcanal!

@sethrj sethrj merged commit ef9b3fd into celeritas-project:develop Dec 7, 2023
18 of 19 checks passed
@pcanal pcanal deleted the installable-root-dictionary branch December 8, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees

@pcanal pcanal

Labels
bug Something isn't working external Dependencies and framework-oriented features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcanal @sethrj