Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Geant4 utilities in preparation for g4vg #1095

Merged
merged 12 commits into from
Feb 2, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Feb 1, 2024

This removes the celeritas/io dependency from the Geant4 volume visitor, and it breaks up the GenericGeoTestBase instantiations into separate files, combining them with the checked geo instantiation.

@sethrj sethrj added minor Minor internal changes or fixes external Dependencies and framework-oriented features labels Feb 1, 2024
@sethrj sethrj requested a review from amandalund February 1, 2024 18:32
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sethrj!

@sethrj sethrj enabled auto-merge (squash) February 2, 2024 18:21
@sethrj sethrj merged commit f0e1697 into celeritas-project:develop Feb 2, 2024
20 of 21 checks passed
@sethrj sethrj deleted the geant-utils-refactor branch February 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Dependencies and framework-oriented features minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants