Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand position check test and fix for other unit systems #1097

Merged

Conversation

amandalund
Copy link
Contributor

See #1094.

@amandalund amandalund added documentation Documentation, examples, tests, and CI field Magnetic field and propagation labels Feb 2, 2024
@amandalund amandalund requested a review from sethrj February 2, 2024 00:34
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sethrj
Copy link
Member

sethrj commented Feb 2, 2024

I think the CI is borking the ROCm jobs that are on hardware:

unknown file: Failure
C++ exception with description "/var/jenkins/workspace/celeritas_PR-1097/src/corecel/sys/KernelAttributes.hh:75:
celeritas: device error: hipFuncGetAttributes(&attr, reinterpret_cast<void const*>(func)) failed:
    shared object initialization failed" thrown in the test body.

@sethrj sethrj merged commit 53648ca into celeritas-project:develop Feb 2, 2024
20 of 21 checks passed
@amandalund amandalund deleted the fix-position-check-test branch February 2, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, examples, tests, and CI field Magnetic field and propagation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants