Split CMake RDC utilities from Celeritas macros #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
changed the title
pcanal
force-pushed
the
to_cuda_rdc_cmake
branch
from
9f29920 to
af67f65
Compare
sethrj
changed the title
sethrj
requested changes
Feb 12, 2024
sethrj
added
core
sethrj
requested changes
Feb 13, 2024
Add missing install of CeleritasUtils.cmake
sethrj
reviewed
Feb 14, 2024
cmake/CeleritasLibrary.cmake
Outdated
|
|
||
| #-----------------------------------------------------------------------------# | ||
| message(AUTHOR_WARNING "Deprecated file. Please use CeleritasUtils.cmake") |
There was a problem hiding this comment.
Actually, don't we want people to only include CudaRdcUtils and use cuda_rdc_add_library? We don't want downstream code to add celeritas-specific aliases.
There was a problem hiding this comment.
Yes, that would be better. In this case we don't need to distribute CeleritasUtils.mk but need to update the examples.
|
@pcanal looks like there's one final issue; not sure why, but the wrapper functions aren't propagating "target includes" for the installed target: |
|
I am looking into it. |
sethrj
reviewed
Feb 14, 2024
Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov>
|
This is where the investment we've spent into CI really pays off... we've had to make like 10 changes to get build, install, test, downstream build working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.