Workaround missing G4persistency target bug in Geant4 11.2 #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geant4 11.2 split the G4persistency target into subcomponents: - G4mctruth - G4geomtext - G4gdml (optional, only if Geant4 built with GDML support) and so projects use the direct CMake targets will fail to link these versions. A bug fix will be made in Geant4 itself to address this. Workaround issue in Celeritas by translating request for "persistency" target in celeritas_get_g4libs to appropriate underlying targets. Use translation rather than creation of our own imported target to: - avoid possible (albeit unlikely) clashes with other projects that might create the same target. - Reduce dependence on use of Celeritas' FindGeant4 wrapper by downstream projects.
drbenmorgan
changed the title
sethrj
added
bug
drbenmorgan
commented
Feb 22, 2024
sethrj
reviewed
Feb 23, 2024
Check obvious case first, then the special cases for persistency and tasking. Post-process list to remove duplicates to avoid ld warnings observed on macOS.
pcanal
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Slack, and the same report on VecGeom JIRA, Geant4 11.2 split the
G4persistencytarget into subcomponents:G4mctruthG4geomtextG4gdml(optional, only if Geant4 built with GDML support)and so projects use the direct CMake targets will fail to link with these versions. A bug fix will be made in Geant4 itself to address this, but we'll still need to support the affected versions of 11.2.
Workaround this issue in Celeritas by translating request for
persistencytarget inceleritas_get_g4libsto appropriate underlying targets. Translation rather than creation of our own imported target was chosen to:Geant4::CMake namespace).